allinurl / allinurl/goaccess

Safari Browser main version should be included in the output

Open
#1,237 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

change enhancement log-processing
Dominant language
C
Stars
20.9k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Safari Browser User-Agents look like this:

  • [...] Version/4.0 Mobile Safari/533.1
  • [...] Version/4.0 Mobile Safari/534.30
  • [...] Version/4.0 Safari/532.21.6
  • [...] Version/4.0 Safari/534.30
  • [...] Version/6.0 Mobile/10A5376e Safari/8536.25
  • [...] Version/6.0 Safari/536.25
  • [...] Version/6.0.3 Safari/536.28.10
  • [...] Version/6.0.4 Safari/536.29.13
  • [...] Version/7.0 Mobile/11A465 Safari/9537.53
  • [...] Version/7.0.3 Safari/537.75.14
  • [...] Version/8.0 Mobile/12B411 Safari/600.1.4
  • [...] Version/8.0 Mobile/12H321 Safari/600.1.4
  • [...] Version/8.0.2 Safari/600.2.5
  • [...] Version/8.0.7 Safari/600.7.12
  • [...] Version/8.0.8 Safari/600.8.9
  • [...] Version/11.0.1 Safari/604.3.5
  • [...] Version/11.0.2 Safari/604.4.7
  • [...] Version/11.0.3 Safari/604.5.6
  • [...] Version/11.0 Mobile/15A372 Safari/604.1
  • [...] Version/11.0 Mobile/15B202 Safari/604.1

You seem to take the latter part, f.e. Safari/604.1, as the version of the used Safari Browser:
goaccess safari example

This seems to be the build number, which can be quite confusing for someone that never used Safari. I think it would be good to include the main number from the Version/ substring:

  • Safari 11.0.3 (604.5.6)
  • Safari 8.0.2 (600.2.5)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Safari user-agent parsing and the output formatting that currently uses the Safari build number. Compare the listed Version/ and Safari/ values across the examples, then check the existing tests or sample output for browser versions. Done means Safari output includes both the main Version/ value and the build number without breaking other Safari variants.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
analytics, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.