alleyinteractive / alleyinteractive/wordpress-fieldmanager

Improve escaping of validation JS

未關閉
#841 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
PHP
星號
563
分支
99
PR 合併指標
30 天內沒有已合併 PR

描述

Replace the invalid uses of `esc_js()` and `esc_attr()` in class-fieldmanager-util-validation.php, e.g. [this block](https://github.com/alleyinteractive/wordpress-fieldmanager/blob/0cb5e63ee4fd96fc06aff0623b6402df9861abdb/php/util/class-fieldmanager-util-validation.php#L267-L276) and [this block](https://github.com/alleyinteractive/wordpress-fieldmanager/blob/dabdd128dcfe5db41b8053f5a2ad21104d3f7c85/php/util/class-fieldmanager-util-validation.php#L329-L335), with more appropriate escaping procedures. The entire file warrants review for updated standards. We should perhaps consider deprecating it in favor of something more modern, ideally that doesn't depend on jQuery.

Props @natebot for noticing.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。