allenai / allenai/bi-att-flow

Predict empty answer with high score

Open
#71 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.5k
Forks
667
PR merge metrics
No merged PRs in 30d

Description

When predicting answer, sometimes I get empty answer, however the score is high enough.
Finally I locate the problem. A function called `_get2` at line 284 and 382 in file `basic/evaluator.py`, the judgement `if len(xi[span[0][0]]) <= span[1][1]:` should be `if len(xi[span[0][0]]) < span[1][1]:`.
When the stop position is at the end of `context`, `span[1][1]` is equal with `len(xi[span[0][0]])`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.