allenai / allenai/ScienceWorld

Anode/Cathode on battery appears reversed

Aperta
#50 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
Scala
Stelle
391
Fork
42
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I think the anode/cathode on the battery (i.e. source) might be reversed. Here's a log showing that, for the electrical circuit task, a circuit connected as such doesn't work:

- Battery anode -> wire -> light anode
- Battery cathode -> wire -> light cathode

But the reverse does appear to work (e.g. anode->cathode instead of anode->anode).

The anode/cathode chaining is required for loads (like the LEDs), but not for the sources (e.g. the battery). Should:
- Check the simulator and fix this bug
- Fix any issues w/gold agents and regenerate training data for these tasks

[log-power-component.html.pdf](https://github.com/allenai/ScienceWorld/files/12295975/log-power-component.html.pdf)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.