allegro / allegro/marathon-consul

ReadinessCheck Support

Open
#175 3 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Go
Stars
200
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Hi,

We have been using Marathon-consul for a while to render Haproxy config using Consul template. Recently we made change in our application to have endpoint for healthcheck to do a regular fast check < 1s to be used in Marathon. We have another endpoint which does a comprensive test which takes ~15S. Till this time, application is not ready to take the requests. So I read about Marathon readiness check and decided to go that route thinking that this will help us in terms of Consul registration based on the readiness check for the new instance. However with my testing it does not look it since my Marathon healthcheck passes <1s, it registers with Consul immediately and haproxy started getting the request.

Do we have a way to control this in Marathon-Consol to register the service only after the readinesscheck passes for the newly spin up instance?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.