allegro / allegro/json-logic-kmp

Release 1.1.7 broken our Android build.

Open
#123 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
66
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Updating to 1.1.7 broke our release build for our Android app. This appears to involve R8 + `kotlinx-datetime` which was added in this commit: https://github.com/allegro/json-logic-kmp/pull/120/commits/9f6027089ab3b049c1abaa0b8e8d6437e80e2a8f.

It looks like `kotlinx-datetime` uses `kotlinx.serialization` and `kotlinx.serialization` requires some specific proguard rules to work. See https://github.com/Kotlin/kotlinx.serialization#android.

The easiest way to reproduce this is to create a new Android app. Ensure Android Gradle Plugin in 8 or higher. Add `json-logic-kmp` v1.1.7 and then do a release build.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.