allegro / allegro/axion-release-plugin

uncommitted changes ignored, but branch name still appended

Offen
#1,065 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Groovy
Sterne
641
Forks
165
Ø Merge
49 Min.
Gemergte PRs (30 T.)
9

Beschreibung

```
plugins {
id("pl.allegro.tech.build.axion-release") version "1.21.3"
}

scmVersion {
localOnly.set(true)
useHighestVersion.set(true)
versionCreator.set(PredefinedVersionCreator.VERSION_WITH_BRANCH.versionCreator)
tag {
prefix.set("")
}
}
```

With this config active, I checked out the branch `next` (anything not `main`) whose most recent commit is tagged with `8.0.0-alpha.3`. Running `currentVersion` returns `8.0.0-alpha.3` as expected.

When adding `ignoreUncommittedChanges.set(false)` without committing, running `currentVersion` returns `8.0.1-next-SNAPSHOT` - also as expected due to the uncommitted config change.

Now changing this to `ignoreUncommittedChanges.set(true)` still without committing changes the outcome of `currentVersion` to `8.0.0-alpha.3-next`. I would rather expect the initial output without the branch name appended.

The SNAPSHOT appender is not active because it ignores the uncommitted changes, and so should the branch name appender.

Haven't checked how other version creators behave in that case

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.