all-contributors / all-contributors/app

Improve bot error messaging on invalid commitType config (Example inside)

Open
#485 11 comments 0 reactions 0 assignees View on GitHub
bug enhancement priority: medium status: waiting for feedback
Dominant language
JavaScript
Stars
634
Forks
168
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When fed a valid request, the bot says it is unable to process the request:

https://github.com/trussworks/react-uswds/pull/2618#issuecomment-1768572938

image

This was due to the repository config using a commitType that also included a scope. Reverting the scope fixed the issue:

![image](https://github.com/all-contributors/app/assets/15805554/b8b585af-2576-4202-8e0d-7b4da6cfac33)

https://github.com/trussworks/react-uswds/pull/2653#issuecomment-1810802029

**To Reproduce**
Steps to reproduce the behavior:

1. Create a repo with an all contributors config file that includes commitType: "chore(someScope)"
2. Try to use the bot
3. Note that it fails. The error sounds like it is network, API, or all-contributors code related. I suspect since it works for others (presumably) that there is actually an issue with our repo or configuration. Note that the bot used to work in this repo.

**Expected behavior**
The bot should properly create the contributor PR

OR

The bot should indicate what the problem is, in this case, specifically handling an error that I assume bubbles up from https://github.com/Berkmann18/commit-conv

**Additional**

Opened an issue with [commit-conv](https://github.com/Berkmann18/commit-conv): https://github.com/Berkmann18/commit-conv/issues/35 to allow scope.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.