Does SimAI support tree topology?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 184
- Avg merge
- 13h 4m
- Merged PRs (30d)
- 1
Description
I recently tried to run a simulation using a tree topology and realized that the genAllReduceFlowModels function is returning the output of genAllReduceRingFlowModels for both the tree and ring topologies. (as seen in this switch case)
Additionally, the tutorial documentation mentions a variable called AS_NVLSTREE_ENABLE to enable NVLSTree, but I couldn't find any trace of this variable in the codebase.
Could you clarify if SimAI currently supports the tree model? If it does, how should it be properly configured?
Thank you!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with astra-sim-alibabacloud/astra-sim/system/MockNcclGroup.cc around the switch at line 664 and trace genAllReduceFlowModels and genAllReduceRingFlowModels. Then compare this behavior with the NVLSTree instructions in docs/Tutorial.md. Done means establishing whether tree topology is supported, identifying the correct configuration, and ensuring the code and tutorial agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- distributed-systems, documentation
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100