aliyun / aliyun/SimAI

[Bug] -busbw parameter documented in README but not supported by SimAI_analytical

Open
#227 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.2k
Forks
184
Avg merge
13h 4m
Merged PRs (30d)
1

Description

Description
The README documents the following command using -busbw parameter:

bash
./bin/SimAI_analytical -w example/workload_analytical.txt -g 9216 -g_p_s 8 -r test- -busbw example/busbw.yaml
However, running this command only prints the help message and exits.

Root Cause
After examining the source code in

astra-sim-alibabacloud/astra-sim/system/AstraParamParse.hh
, the parameter parsing logic does not include -busbw. When the parser encounters this unknown argument, it falls into the else { return 1; } branch (line ~169), which triggers the help message output.

The actual supported bandwidth parameters are:

-nv / --nvlink (NVLink bandwidth)
-nic / --nic_busbw (NIC bandwidth)
-n_p_s / --nic_per_server (NICs per server)
Workaround
Use explicit bandwidth parameters instead:

bash
./bin/SimAI_analytical -w example/workload_analytical.txt -g 9216 -g_p_s 8 -r test- -nv 360 -nic 48.5 -n_p_s 8
Expected Behavior
Either:

Add -busbw parameter support to parse the busbw.yaml file, or
Update the README to remove the -busbw example and clarify the correct usage
Environment
OS: Ubuntu (PowerEdge R750)
Compiler: GCC 12.3.0
Branch: main

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with AstraParamParse.hh, where the documented -busbw argument is rejected, and compare it with the README command and the listed supported bandwidth options. Decide whether the intended resolution is parser support for busbw.yaml or a README correction; done means the documented command behaves consistently with the supported interface.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.