Infinite loop when the -c parameter of the SimAI_simulator command is empty
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 184
- Avg merge
- 13h 4m
- Merged PRs (30d)
- 1
Description
I noticed that the parameter -c is required in the new version v1.0, and tutorial has not been updated yet. Using SimAI_simulator without -c will result in an infinite loop, I think this is due to this code segment:
bool ReadConf(string network_topo,string network_conf) {
std::ifstream conf;
conf.open(network_conf);
topology_file = network_topo;
while (!conf.eof()) {
std::string key;
conf >> key;
Should exception handler added?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ReadConf function shown in the issue and trace how SimAI_simulator handles an empty -c argument. Check the tutorial's command examples as well. Done means the command no longer loops indefinitely when -c is omitted and the tutorial reflects the required parameter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100