aliyun / aliyun/SimAI

Question about SingleFlow.prev in ring all-reduce

Open
#162 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.2k
Forks
184
Avg merge
13h 4m
Merged PRs (30d)
1

Description

In the first round of Ring All-Reduce, why is the prev field of SingleFlow set to the previous rank?
Isn't the first-round flow supposed to be initiated independently by each rank?
Why does it need a prev rank?

Code is in MockNcclGroup.cc: line 1168.

if(rank_it->second[0]!=-1){
  prevranks={rank_it->second[0]};
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read MockNcclGroup.cc at line 1168 and trace SingleFlow.prev through the first ring all-reduce round. Compare the flow construction with the per-rank initiation described in the issue; done means documenting why prev is set and whether the implementation matches the intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.