alicevision / alicevision/AliceVision

PCL is an unused dependency?

Open
#2,012 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
3.5k
Forks
881
Avg merge
4d 7h
Merged PRs (30d)
3

Description

I just noticed that the PCL dependency in Dependencies.cmake is currently unused. No target depends on it and afaik no source file actually uses it. I think it got merged with #1258. But that PR expected a later one to be merged as well (#425), which was actually just closed.

Are there any plans on keeping PCL around or should we remove it as a dead dependency, just like we did for OpenGV (#1980)?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Dependencies.cmake and search the repository for PCL references, including targets and source files. Confirm whether any active configuration still requires it; done means either documenting a concrete reason to retain it or removing the unused dependency consistently, following the precedent of OpenGV (#1980).

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.