alibaba / alibaba/x-deeplearning

The implementation of the Attention function is different from the description in DIEN paper.

Open
#297 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PureBasic
Stars
4.3k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

In `Model_DIEN` the attention weights are calculated by `din_fcn_attention()`, which seems same as `din_attention()` except for:
```
query = tf.layers.dense(query, facts_size, activation=None, name='f1' + stag)
query = prelu(query)
```
And I think this is different from the description in the DIEN paper:
![image](https://user-images.githubusercontent.com/6280748/68758530-ee153280-0648-11ea-944c-0d5c75c74c48.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with Model_DIEN and compare din_fcn_attention() with din_attention(), focusing on the query dense layer and prelu call shown in the issue. Read the DIEN paper's attention description and determine whether the implementation should match it; done means the behavior and corresponding validation reflect the paper or the discrepancy is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
tensorflow
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.