alibaba / alibaba/structure-view

Unintuitive toggle behavior

Open
#36 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
35
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Atom 1.34.0
macOS High Sierra 10.13.6
structure-view 0.2.1

Toggling the structure-view seems quite unintuitive.
By default, it seems to open in a right pane. Usually Git and Github tabs are open on the right as well. Keeping that in mind, I have trouble in some use cases.

Case 1: Structure-view is already open and is focused (toggle works as expected).
Case 2: The structure-view is closed but the right pane is open. Toggle closes the right pane first, and it requires another toggle to open the structure-view. Expected behavior: it should open the structure-view with directly on the right pane.
Case 3: The structure-view is open, the right pane is open, but it's focused on something else (such as the git tab). The same as Case 2, the toggle first closes the pane and reopen with another toggle. Expected behavior: it should change the focus onto the structure-view tab with one toggle.

By "toggling" it's expected to either open or close. I don't think it makes sense to toggle twice to open. Moreover, it shouldn't close the pane where structure-view is not even present.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the toggle behavior in Atom 1.34.0 on macOS High Sierra with structure-view 0.2.1, checking each of the three cases described. Trace the toggle behavior and verify that one toggle opens or focuses structure-view without first closing an unrelated right pane; done means all three expected behaviors work consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.