alibaba / alibaba/nginx-http-sysguard

About the patch

Open
#4 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C
Stars
254
Forks
84
PR merge metrics
No merged PRs in 30d

Description

How about using module context to save the state instead of providing a patch?

something like
# line 188

--if (r->main->sysguard_set) {
++ctx = ngx_http_get_module_ctx(r, ngx_http_sysguard_module);
++if (ctx != NULL || r->internal) {

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the module source around line 188 and inspect how the current sysguard state is stored and read. Compare that flow with the proposed module-context approach, then verify the module still handles internal requests and preserves its existing protection behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, nginx
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.