alibaba / alibaba/libgrape-lite

Support building with `glog` 0.7.1 and/or `ng-log` 0.8.2

Open
#180 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
442
Forks
102
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
libgrape-lite currently does not build with the final `glog` release (0.7.1) or current `ng-log` release (0.8.2)

**Describe the solution you'd like**
Easiest option for now is to update CMake scripts to use `glog-config.cmake` and fall back to module. This will at least work until `ng-log` 0.9.x

**Describe alternatives you've considered**
With original `glog` no longer maintained (https://github.com/google/glog?tab=readme-ov-file#google-logging-library), may need to consider one of following in the future but they will require more changes:
1. Adding direct support for `ng-log` without compatibility layer which will be removed in 0.9.x
2. Switching to another logging library (Google's replacement option is `abseil` logging)

**Additional context**
Opening this issue for Homebrew as we are trying to update `glog` and right now `libgrape-lite` is one of the projects that doesn't build with newer `glog` or `ng-log`.

Contributor guide

Open the contributing guide

Research direction

Start by locating the repository's CMake scripts and how they find glog or ng-log. Build libgrape-lite against glog 0.7.1 and ng-log 0.8.2, then verify that the CMake configuration succeeds using the requested config-file lookup with module fallback.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.