alibaba / alibaba/async_simple
Handle executor's schedule/checkin return value
- Dominant language
- C++
- Stars
- 2.2k
- Forks
- 316
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 3
Description
### Search before asking
- [x] I searched the [issues](https://github.com/alibaba/async_simple/issues) and found no similar issues.
### What happened + What you expected to happen
https://github.com/alibaba/async_simple/blob/5d14230047e1e111ebc7f5a9ee963cbd940d4dd6/async_simple/coro/ViaCoroutine.h#L66
If executor's checkin method returned false and task not be executed, this may caused the lazy can not resumed.
We should handle the return value, how about to add the logicAssert?
### Reproduction way
### Anything else
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at async_simple/coro/ViaCoroutine.h around line 66 and inspect the executor checkin contract and its return value. Verify the path where checkin returns false and the lazy task is not resumed; done means that this failure is handled explicitly and the task cannot remain silently unscheduled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100