alibaba / alibaba/Sentinel

Move integration tests outside of sentinel-core

Open
#470 0 comments 0 reactions 0 assignees View on GitHub
area/test kind/enhancement
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

## Issue Description

Type: *bug report*

### Describe what happened (or what feature you want)
Building `sentinel-core` takes a bit more than 1 minute to complete.

$ mvn -am -pl sentinel-core test
....
[INFO] Reactor Summary for sentinel-parent 1.4.2-SNAPSHOT:
[INFO]
[INFO] sentinel-parent .................................... SUCCESS [ 0.521 s]
[INFO] sentinel-core ...................................... SUCCESS [01:00 min]

This is due to a handful of integration tests that have fixed wait times to reproduce a particular state. All projects dependent on `sentinel-core` must wait until it has been compiled and tested before continuing. Speeding up `sentinel-core` will speed up the build.

*Proposal:* move slow tests and integration tests to a new project`sentinel-integration-tests`.

### Describe what you expected to happen
Builds should be as fast as they can in order to
* reduce amount of time waiting for a PR to be check on CI server.
* reduce amount of energy spent
* enable a faster feedback loop

### How to reproduce it (as minimally and precisely as possible)

1. mvn -am -pl sentinel-core test

### Tell us your environment

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00)
Maven home: /Users/aalmiray/.sdkman/candidates/maven/current
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_191.jdk/Contents/Home/jre
Default locale: en_CH, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"

### Anything else we need to know?
Candidate tests to be moved to `sentinel-integration-tests`:
* com.alibaba.csp.sentinel.AsyncEntryIntegrationTest
* com.alibaba.csp.sentinel.node.StatisticNodeTest
* com.alibaba.csp.sentinel.slots.block.degrade.DegradeTest
* com.alibaba.csp.sentinel.slots.block.flow.controller.WarmUpControllerTest
* com.alibaba.csp.sentinel.slots.block.flow.FlowPartialIntegrationTest

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.