alibaba / alibaba/Sentinel

[BUG] 指标文件读取方法不正确

Open
#3,462 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/alibaba/Sentinel/blob/195150bc745927429e9f14f501907310b46d702f/sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricSearcher.java#L208-L211

209行 offset = indexIn.readLong(); 不应该写, 应该剔除这行, 这样会导致读取的数据不正确

假如读取的是 1729965161000L的数据, 返回的是1729965162000L及之后的数据,
但如果1729965161000L是文件的最后一个时间的记录数据, 又会被读取到
```
List metricNodes = searcher.find(1729965161000L, 5);
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.