alibaba / alibaba/Sentinel

Sentinel的扩展模块 “sentinel-extension\sentinel-prometheus-metric-exporter” 是否有必要?

Open
#3,461 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

最近读`Sentinel`源码,发现里面多出一个扩展模块 `sentinel-prometheus-metric-exporter`,基于之前对`Sentinel`的使用经验,对其必要性产生怀疑,理由如下:
我们知道,在`Sentinel`中有个`sentinel-dashboard`模块,其中有个类`src/main/java/com/alibaba/csp/sentinel/dashboard/repository/metric/InMemoryMetricsRepository.java`, 这个类是在内存中保留了各节点5分钟的监控信息,既然监控信息已经收集起来了, 为什么不直接在这里扩展一个`metric-exporter`,所有的节点监控都在这里暴露了,这样不用麻烦在每个应用内开一个`metric-exporter`,应用只用关注自己的业务开发即可。

Contributor guide

Open the contributing guide

Research direction

Compare the sentinel-extension/sentinel-prometheus-metric-exporter module with sentinel-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/repository/metric/InMemoryMetricsRepository.java. Start by tracing where dashboard metrics are collected and how the exporter is used. Done requires a maintainer-approved decision on the proposed architecture and a concrete scope, since the issue currently asks whether the module is necessary rather than specifying a change.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, prometheus
Domain
observability
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.