alibaba / alibaba/Sentinel

[BUG] 使用来源白名单功能时,没有设置orgin的客户端请求会立即通过,功能失效。

Open
#3,408 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

一、详细说明:
使用来源白名单功能时,没有设置orgin的客户端请求会立即通过,功能失效。
二、漏洞证明(在这里写POC):
github上最新的代码:
https://github.com/alibaba/Sentinel/blob/master/sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/block/authority/AuthorityRuleChecker.java
![image](https://github.com/alibaba/Sentinel/assets/1516363/dabbcbf9-ed68-4b6a-9de4-f1223a98fa05)
三、修复方案:
应去掉StringUtil.isEmpty(requester)的判断,否则白名单功能失效,产生非法访问的漏洞。

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.