[BUG] other flow rules should act on empty origin
Open
- Dominant language
- Java
- Stars
- 23.1k
- Forks
- 8.1k
- PR merge metrics
- No merged PRs in 30d
Description
other flow rules should act on empty origin, otherwise the resource annotated with @SentinelResource will not be restricted by other rules.
in FlowRuleManager
```
public static boolean isOtherOrigin(String origin, String resourceName) {
if (StringUtil.isEmpty(origin)) {
return false;
}
```
Contributor guide
Research direction
Start in FlowRuleManager at the isOtherOrigin method shown in the issue and trace how an empty origin is handled for @SentinelResource flow rules. Confirm the intended behavior for empty origins and verify that other flow rules can restrict the annotated resource when the change is complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100