alibaba / alibaba/Sentinel

Micrometer Observation Support

Open
#3,235 1 comment 0 reactions 0 assignees View on GitHub
area/metrics kind/feature
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

## Issue Description

Type: *feature request*

### Describe what feature you want

I'm a co-maintainer of [Spring Cloud Sleuth](https://github.com/spring-cloud/spring-cloud-sleuth/) and [Micrometer](https://micrometer.io/) projects (together with @shakuzen and @jonatan-ivanov).

[Micrometer Observation](https://micrometer.io/docs/observation) is part of the Micrometer 1.10 release and [Micrometer Tracing](https://micrometer.io/docs/tracing) is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit).

I was curious if there's interest in adding Micrometer Observation support so that except for metrics, spans could be created and tracing context propagation could happen too. Via Micrometer Tracing one can use OpenTelemetry or OpenZipkin Brave Tracer, but with the handler mechanism the possibilities are endless :)

### Describe your initial design (if present)

We would need to find egress and ingress points (getting messages / requests, sending messages / requests) and instrument those using Micrometer Observation API.

### Additional context

There's already quite a few projects that we support https://github.com/micrometer-metrics/micrometer/blob/main/docs/modules/ROOT/pages/observation/projects.adoc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.