alibaba / alibaba/Sentinel

Should we need to extract the instance of file-datasource to a separate module?

Open
#2,533 1 comment 0 reactions 0 assignees View on GitHub
area/data-source kind/discussion
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

## Issue Description

### Describe what happened (or what feature you want)

sentinel-datasource-extension should be the super module of datasource-extension who defining the rules of datasource, rules include some common classes or some interfaces or some abstract classes. But there are some datasource instance in this module like file-datasource. So I think we need to extract the instance of file-datasource to a separate module.

Contributor guide

Open the contributing guide

Research direction

Start by reading the sentinel-datasource-extension and datasource-extension module definitions, then locate the file-datasource instances described in the issue. Done means the shared module contains only datasource rules and common abstractions, while the file-datasource implementation is provided by a separate module.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.