alibaba / alibaba/Sentinel

some super class in project sentinel-datasource-extension is not convenient to extend both ReadableDataSource and WritableDataSource

Open
#2,520 0 comments 0 reactions 0 assignees View on GitHub
area/data-source
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

## Issue Description
1、'AbstractDataSource' can only support ReadableDataSource but the name seems that can support Writeabled too.
2、'Converter' can only support one converter from S to T, can not support T to S

### Describe what happened (or what feature you want)
1、split 'AbstractDataSource‘ to two partitions to Isolation function, make it follow Single responsibility
2、provide T coonverter to S in 'Converter' to suite two-way-converter requires

Contributor guide

Open the contributing guide

Research direction

Start by reading AbstractDataSource, Converter, ReadableDataSource, and WritableDataSource in sentinel-datasource-extension, then compare how readable and writable behavior is currently separated. Done means the datasource abstraction follows single responsibility and Converter supports the requested two-way conversion without breaking existing uses.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.