alibaba / alibaba/Sentinel

FlowPropertyListener中的configUpdate需要优化

Open
#2,344 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

FlowPropertyListener中方法已经使用了synchronized,FlowRuleUtil.buildFlowRuleMap(value); 是否还有必要返回ConcurrentHashMap?。
并且flowRules是hashMap。在方法中被莫名其妙的替换成了ConcurrentHashMap类型。

Contributor guide

Open the contributing guide

Research direction

Locate FlowPropertyListener and inspect configUpdate, including its synchronized scope and the call to FlowRuleUtil.buildFlowRuleMap(value). Trace how flowRules changes between HashMap and ConcurrentHashMap, then verify the intended map type and concurrency behavior with the relevant existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.