alibaba / alibaba/Sentinel

I wonder why just ignore the coding rule called "PMD.ThreadPoolCreationRule" instead of fixing them? Could you please explain it?

Open
#2,023 1 comment 0 reactions 0 assignees View on GitHub
kind/enhancement
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

## Issue Description

Type: *bug report* or *feature request*

### Describe what happened (or what feature you want)
![image](https://user-images.githubusercontent.com/16860171/107454044-3b06f200-6b87-11eb-9512-454d87c24f37.png)

I saw a few of **@SuppressWarnings("PMD.ThreadPoolCreationRule")** in many classes.
(e.g **SimpleHttpCommandCenter.java , NettyHttpCommandCenter.java**)
Why did you just ignore them instead of fixing?
What if tremendous task queued in blocking queue?
It may cause OutOfMemory problem according to Alibaba Java Coding Guidelines.

### Describe what you expected to happen
If possible, I will submit a PR for fixing it.
Looking forward to your reply. Thanks!

### How to reproduce it (as minimally and precisely as possible)
NONE

### Tell us your environment
NONE

### Anything else we need to know?
NONE

Contributor guide

Open the contributing guide

Research direction

Start with the PMD.ThreadPoolCreationRule suppressions in SimpleHttpCommandCenter.java and NettyHttpCommandCenter.java, then inspect the related thread-pool and blocking-queue configuration. Compare the implementations with the rule's concern about unbounded task growth; done means the reason for suppression is documented or the affected implementations and tests are updated to address the reported risk.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.