alibaba / alibaba/Sentinel

System Flow control QPS mode is not accurate in high concurrency

Open
#1,470 2 comments 0 reactions 0 assignees View on GitHub
kind/discussion
Dominant language
Java
Stars
23.1k
Forks
8.1k
PR merge metrics
No merged PRs in 30d

Description

## Issue Description
*bug report*

### Describe what happened (or what feature you want)
System Flow control QPS mode is not accurate in high concurrency

![1](https://user-images.githubusercontent.com/42017997/81462992-d1694a00-91e8-11ea-8195-bdcc31c1e38f.jpg)

I think "Constants.ENTRY_NODE.successQps()" should be replaced by "Constants.ENTRY_NODE.passQps()"

becasue "passQps()" in StatisticSlot.entry() increase, but "successQps()" in StatisticSlot.exit() increase,

![2](https://user-images.githubusercontent.com/42017997/81463185-12159300-91ea-11ea-9a0d-cb6f0630b68d.jpg)

![3](https://user-images.githubusercontent.com/42017997/81463176-01651d00-91ea-11ea-94ce-f4d6cd1348a0.jpg)

Contributor guide

Open the contributing guide

Research direction

Start at the system flow-control QPS logic that reads Constants.ENTRY_NODE and compare it with StatisticSlot.entry() and StatisticSlot.exit(), where passQps() and successQps() are updated. Reproduce the high-concurrency behavior, determine which metric the control should use, and verify that the reported QPS becomes accurate under load.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.