alibaba / alibaba/FederatedScope
Incorrect arguments to SHAWrapFedex init method
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 261
- PR merge metrics
- No merged PRs in 30d
Description
It seems like the ```SHAWrapFedex``` missed to take ```client_cfgs```. Please check.
The Line https://github.com/alibaba/FederatedScope/blob/7f0af2d7aa1537b1a033f4817fbdb62b44e10ac6/federatedscope/autotune/algos.py#L65
```py
elif init_cfg.hpo.scheduler.startswith('wrap', client_cfgs):
scheduler = SHAWrapFedex(init_cfg)
```
perhaps to be changed to
```py
elif init_cfg.hpo.scheduler.startswith('wrap'):
scheduler = SHAWrapFedex(init_cfg, client_cfgs)
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in federatedscope/autotune/algos.py at the scheduler-selection code around line 65, then inspect the SHAWrapFedex initializer and its callers. Confirm how client_cfgs should be passed and verify that the wrap scheduler branch accepts the intended arguments without changing other scheduler behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100