alibaba / alibaba/DataX

FilterTransformer对value的判断不合理

Open
#1,383 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
17.4k
Forks
5.7k
PR merge metrics
No merged PRs in 30d

Description

com.alibaba.datax.core.transport.transformer.FilterTransformer#evaluate``

columnIndex = (Integer) paras[0];
code = (String) paras[1];
value = (String) paras[2];


if (StringUtils.isEmpty(value)) {
throw new RuntimeException("dx_filter para 2 can't be null");
}

这个判断value值的地方,明明报错是不能为空。但是我先过滤掉空串也不行,是不是考虑改成value==null更更合适

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at com.alibaba.datax.core.transport.transformer.FilterTransformer#evaluate and inspect how the value parameter is validated. Reproduce the reported behavior for an empty string and a null value, then confirm the intended error condition from the existing message. Done means the validation matches the documented expectation and the relevant behavior is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.