alibaba / alibaba/ClickSEG

Format of crop_size

Open
#6 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
41
Forks
47
PR merge metrics
No merged PRs in 30d

Description

Is crop_size in the [height, width] format or [width, height]?

Here it's [height, width]:
https://github.com/alibaba/ClickSEG/blob/main/models/strongbaseline/mobilenetv2_x1_comb.py#L41

However,
https://github.com/alibaba/ClickSEG/blob/d61a76b2c88c56106e97d505ce41d16aa2535021/isegm/data/aligned_augmentation.py#L50
uses opencv's convention of [width, height]

Practically, this does not matter because it's a square, but then you could have used just one parameter instead of two.

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare crop_size handling in models/strongbaseline/mobilenetv2_x1_comb.py at line 41 with isegm/data/aligned_augmentation.py at line 50, including OpenCV's width-height convention. Determine the intended ordering and document or consistently apply it; done when the convention is unambiguous and the square-only behavior is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.