alibaba / alibaba/BladeDISC

Fix aten::dropout lowering, aka disc:rng_uniform_custom_call lowering

Open
#615 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
933
Forks
169
PR merge metrics
No merged PRs in 30d

Description

`aten::dropout` was lowering directly to `mhlo_disc::CustomCallOp` see https://github.com/alibaba/BladeDISC/commit/c53e2b21379617d39f720926342f44458c2a6360; It was reverted in PR https://github.com/alibaba/BladeDISC/pull/580, which chosen to lower to `mhlo::RngOp` first. cc @Yancey1989

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare commit c53e2b21379617d39f720926342f44458c2a6360 with PR 580, starting from the aten::dropout and disc::rng_uniform_custom_call lowering paths. Determine the intended lowering and add regression coverage showing that aten::dropout lowers correctly without the reported failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, pytorch
Domain
compilers, machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.