alibaba / alibaba/AliOS-Things

[Bug Report]: Patch for CVE-2020-8169 in reused component curl

Open
#2,020 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C
Stars
4.6k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

### Contact Details

weitingcai2020@gmail.com

### What happened?

我通过使用V1SCAN(一个扫描存在于复用代码中1-Day漏洞的工具),发现您的项目中components/curl/lib/url.c文件中的`override_login`函数可能存在CWE-200 Exposure of Sensitive Information to an Unauthorized Actor漏洞,相关触发逻辑类似https://github.com/advisories/GHSA-whwh-vhp2-pj62, 具体参考链接如下:

CVE-2020-8169:
NVD说明链接:
https://nvd.nist.gov/vuln/detail/CVE-2020-8169
commit修复链接:
https://github.com/curl/curl/commit/600a8cded447c

修复方法:
在components/curl/lib/url.c文件中的override_login函数中, 位于2878和2883行的代码 `uc = curl_url_set(data->state.uh, CURLUPART_USER, *userp, 0);`
均修改为:
`uc = curl_url_set(data->state.uh, CURLUPART_USER, *userp, CURLU_URLENCODE);`

考虑到其可能存在的潜在风险,我愿意配合您以负责任的方式及时核实、解决和报告发现的漏洞。 如果您需要任何进一步的信息或帮助,请随时与我联系。如果需要,我也可以提交PR帮助您修复。 谢谢您,期待尽快收到您的回复!

### Version

master (Default)

### What soultions are you seeing the problem on?

_No response_

### Relevant log output

_No response_

Contributor guide

Open the contributing guide

Research direction

Start in components/curl/lib/url.c at the override_login function and compare the cited upstream curl commit 600a8cded447c for CVE-2020-8169. Confirm the affected URL-user handling matches the reported security fix and that the vendored component contains the correction; the issue is done when the vulnerability is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.