algorand / algorand/js-algorand-sdk

Replace instanceof checks with other type check

Open
#740 10 comments 1 reaction 0 assignees View on GitHub
bug good first issue Team Lamprey
Dominant language
TypeScript
Stars
297
Forks
214
Avg merge
1h 3m
Merged PRs (30d)
3

Description

## Problem

when a different version of the algosdk is used from another dependency, the instanceof checks fail and result in confusing error messages.

Instead we should find another way to do the type check like https://www.typescriptlang.org/docs/handbook/2/typeof-types.html#the-typeof-type-operator

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.