algorand / algorand/js-algorand-sdk

ECMAScript target version mismatch with cicd env

Aperta
#626 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
new-bug Team Lamprey
Lingua principale
TypeScript
Stelle
297
Fork
214
Merge medio
1h 3m
PR unite (30g)
3

Descrizione

### Subject of the issue

Our unit-tests with Circleci run in node12 which supports es2019. Our tsconfig target is es2020.

### Steps to reproduce

1. make a function that uses optional chaining
2. build
3. check the /dist folder, you'll see the optional chaining won't be downcompiled, as it's es2020 syntax.

### Expected behaviour

Optional chaining, non-nullish coalescing operator and others are all features of es2020. They're essential to write modern js. We should either bump the node version in cicd to 14 - 12 being past its end of life anyway - or set a es2019 target in our tsconfig.

### Actual behaviour

Any function using es2020 features unsupported by node12 will fail in testing.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.