algorand / algorand/java-algorand-sdk

TransactionId empty if SignedTransaction initialized by constructor @JsonCreator

Ouverte
#424 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug Team Lamprey
Langage dominant
Java
Étoiles
73
Forks
71
Merge moyen
41 min
PR mergées (30 j)
2

Description

## Problem

The SignedTransaction created by deserialization JSON (@JSONCreator) doesn't fill the attribute transactionId.
https://github.com/algorand/java-algorand-sdk/blob/develop/src/main/java/com/algorand/algosdk/transaction/SignedTransaction.java#L80

So with Atomic Composer if I put a TxnSigner as a external request that works with deserialization of SignedTransaction, It will not work cause the transactionId is emtpy.
https://github.com/algorand/java-algorand-sdk/blob/develop/src/main/java/com/algorand/algosdk/transaction/AtomicTransactionComposer.java#L188

## Solution

We could add the transactionId into the constructor through@JSONCreator or other options proposed by barnji:
instead of using the txid directly from signed transaction object, use signedtransaction.tx.getTxId() or w/e its called in the atc.
it'd be redundant hashing possibly but safer in the case of a enc/dec stxn

## Dependencies

No dependencies

## Urgency

Low Urgency, easy to implement a workaround

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.