algorand / algorand/go-algorand

Add goal support for multiple Ledger Nano accounts

オープン
#1,930 コメント 7 件 リアクション 10 件 担当者 0 名 GitHub で見る
community interest Team Scytale
主要言語
Go
スター
1.4k
フォーク
537
平均マージ
1日 6時間
マージ済み PR(30日)
17

説明

## Is your feature request related to a problem? Please describe.

The Ledger Nano supports multiple accounts for every coin I've used with it. For Algorand, Ledger Live supports this for Algorand as well. However, the goal CLI which supports the Ledger well, does NOT support multiple accounts. It only supports account 0.

Trying to add a new account yields:
```
> goal wallet new -w Ledger-Nano-X-0001-XXXXXXX
Error processing command: operation not supported by wallet
```

## Describe the solution you'd like.

Just like you can create a new wallet with a seed and create the same accounts from that seed, the ledger works the same way. Any accounts added via Ledger Live should all be visible via Goal. This is required in particular for signing 'online/offline' transactions. I'll often use goal for sends as well via goal clerk send.

The key is, all the normal operations should work cleanly, list, new, and use of the accounts at a minimum.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。