algolia / algolia/shipjs

New strategy to trigger release?

Open
#714 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
776
Forks
27
PR merge metrics
No merged PRs in 30d

Description

[List pull requests associated with commit
](https://developer.github.com/v3/repos/commits/#list-pull-requests-associated-with-commit)

For now, the condition to trigger release is

```
correctCommitMessage && correctBranch
```

(https://github.com/algolia/shipjs/blob/master/packages/shipjs-lib/src/lib/config/defaultConfig.js#L88-L107)

What if it becomes

```
(correctCommitMessage || prLabeled) && correctBranch
```

`prLabeled` here means if the PR associated with the latest commit message has a specific label like "release:trigger".

This might solve issues like #667

Is there any side effect?

Should it become a default behavior? or an opt-in feature?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with packages/shipjs-lib/src/lib/config/defaultConfig.js at the referenced condition, then review GitHub’s API for listing pull requests associated with a commit. Trace how release triggering currently uses the commit message and branch, and assess the proposed PR-label path, its side effects, and whether the behavior should be opt-in or default.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript
Domain
ci-cd, release
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.