algolia / algolia/shipjs

can't trigger release if a commit has happened since the "release" commit

Open
#667 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
776
Forks
27
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

When you prepare a release, but after merging you see something small is missing, I don't want to prepare the release again.

**To Reproduce**
Steps to reproduce the behavior:
1. shipjs prepare
2. git commit -m "something else"
3. shipjs trigger

**Expected behavior**

The last prepare which was not yet released will now be released, but only if the changes _since_ the last release `chore`, `docs`, maybe `fix`?

**Screenshots**

```
Skipping a release due to the following reason:
> The commit message should have started with the following:
chore: release v1.4.0
```

**Environment (please complete the following information):**
- environment: your local machine
- Ship.js version: 0.13.1

**Additional context**

For now what I do is enable force pushing on the repo, making the fix in a separate commit, but reordering so the release commit is latest again, then disabling force push again

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the sequence with `shipjs prepare`, a subsequent `git commit`, and `shipjs trigger`; then trace the `shipjs trigger` entry point where the release-commit message is validated. Done means the last unreleased prepare can be triggered after an allowed subsequent commit, without force-pushing or preparing again, while preserving the intended commit rules.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, javascript
Domain
release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.