algolia / algolia/setup-algolia-cli

Latest is not the latest actually

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Description

In the README it is said that the default value for the `version` input is `latest`, though it's not the case anymore after https://github.com/algolia/setup-algolia-cli/commit/ecd8ce364b0b18dda462fd3edfa94d0c7da17838 (a fix for #1).

https://github.com/algolia/setup-algolia-cli/blob/ecd8ce364b0b18dda462fd3edfa94d0c7da17838/action.yml#L6-L10

Ideally, the proper implementation for `latest` is awaited. Though it may be not so straightforward as described in [the docs](https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases) because the file name is not static.

Anyhow, having outdated `1.2.0` as a hard-coded default version doesn't make much sense because the CLI evolves constantly. Currently it's 1.4.2. You'd have to create a new version of this action every time a new version of CLI comes out.

Or at least a correction of the README is necessary to avoid confusion. I'd suggest removing the default altogether in this case.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.