algolia / algolia/instantsearch-android

Multiple Crashes from Workmanager that Algolia brings in transitively

Open
#431 0 comments 0 reactions 1 assignee Claimed by @afrencalg View on GitHub
Dominant language
Kotlin
Stars
159
Forks
32
Avg merge
7d 22h
Merged PRs (30d)
2

Description

**Describe the bug 🐛**
Algolia sdks bring in workmanager transitively. Would it be possible to make that an optional dependency that can be left out?
**Reason:** WorkManager causes too many crashes from what we see in our KPIs and these are hard to avoid because they circumvent even the uncaughtexceptionhandler of workmanager library itself.

**Dependency chain:**
**com.algolia:instantsearch-insights-android:4.0.1:** it looks like it uses WorkManager to flush analytics events to Algolia in the background. The chain is:
```
└── com.algolia:instantsearch-android:4.0.1
└── com.algolia:instantsearch-insights:4.0.1
└── com.algolia:instantsearch-insights-android:4.0.1
└── androidx.work:work-runtime-ktx:2.11.0
└── androidx.work:work-runtime:2.11.0
```

**To Reproduce 🔍**
Steps to reproduce the behavior:
It is hard to reproduce this. This is from our crashlytics. The main path for this crash is as explained here. https://issuetracker.google.com/issues/466592746

**Expected behavior 💭**
Would it be possible to remove workmanager as a dependency or make it an optional one so that we can depend on Algolia SDKs without needing to bring in WorkManager?

**Environment:**
- OS: [android]
- Library Version: 4.0.1 : com.algolia:instantsearch-insights-android:4.0.1

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.