algolia / algolia/docsearch-scraper

[core] Setting attributesForFaceting from the config overrides Algolia settings

Open
#490 2 comments 1 reaction 0 assignees View on GitHub
bug help wanted need_fix_test
Dominant language
Python
Stars
322
Forks
115
PR merge metrics
No merged PRs in 30d

Description

# Situation

When a configuration includes `custom_settings.attributesForFaceting`, the index's setting `attributesForFaceting` does not include `tags` anymore. This override the `default_settings` defined by the strategy. `tags` defined from `start_urls` are not longer handled as `attributesForFaceting`

# Result:

It might broke the search for owner filtering over `tags` and break the search. Happens a lot with people using meta tags.

# Workaround

Make sure configuration defines `tags` as a item from the collection `custom_settings.attributesForFaceting`

Contributor guide

Open the contributing guide

Research direction

Start by tracing how custom_settings.attributesForFaceting and the strategy's default_settings are combined. Verify that tags from start_urls remain included in the index's attributesForFaceting, and confirm the owner-filtering search behavior after the settings are applied.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.