algolia / algolia/algoliasearch-django
Hardcoded `wait_for_tasks` parameter value in `save_record`, `update_records`, and `delete_record` methods
- Dominant language
- Python
- Stars
- 180
- Forks
- 61
- PR merge metrics
- No merged PRs in 30d
Description
This parameter is `False` by default in the `algoliasearch` library.
I do not understand why it has been hardcoded to `True` in the `save_record`, `update_records`, and `delete_record` methods without any option to choose the behavior. This should either be exposed through the API of the methods that make this calls or be configurable via settings.
In my case, this is causing indexations that took 0.5 seconds with v3 to take 10 seconds with v4.
Would it be possible to choose the behavior in some way?
Contributor guide
Research direction
Locate the save_record, update_records, and delete_record methods and trace how they call the algoliasearch library with wait_for_tasks. Compare the default behavior with the current hardcoded value and determine how callers configure the choice. Done means the three methods provide a documented way to select the behavior without forcing wait_for_tasks=True.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- django, python
- Domain
- backend, search
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100