algolia / algolia/algoliasearch-client-php

[bug]: Return type mismatches in SearchClient

Open
#749 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
697
Forks
112
PR merge metrics
No merged PRs in 30d

Description

### Description

The following error is shown here only as an example for the `deleteIndex` method. It also affects all other methods, as far as I can see.

According to PHPDoc, `deleteIndex` returns `array|DeletedAtResponse`, but in fact `sendRequest` returns the response of the `handleResponse` method (ApiWrapper.php), which is an `array` and not an object. Therefore, the `deleteIndex` method never returns the described object of type `DeletedAtResponse`, making it impossible to call `valid`, for example, to check whether the response was successful or not.

### Client

Search

### Version

latest

### Relevant log output

```shell

```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.