algolia / algolia/algoliasearch-client-go

Handle `autoGenerateObjectIDIfNotExist` parameter for `replaceAllObjects()` method

Open
#571 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
200
Forks
60
PR merge metrics
No merged PRs in 30d

Description

The `autoGenerateObjectIDIfNotExist` boolean parameter is for now only valid in
the context of the `saveObjects()` method. As pointed out by @julienpa, it would
make sense to also accepts it as a valid parameter of `replaceAllObjects()`.

For backward-compatiblity, let's make sure the default behavior of calling
`replaceAllObjects()` without the `autoGenerateObjectIDIfNotExist` parameter is
still considered as if it was set to `false`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Find the Go implementation and tests for replaceAllObjects(), then compare its parameter handling with saveObjects(). Verify that the parameter is accepted for replacement requests, that omitting it preserves false behavior, and that tests cover both the omitted and enabled cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.