alexaubry / alexaubry/BulletinBoard

Dark mode support cannot be overridden at runtime

Ouverte
#174 0 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Swift
Étoiles
5.3k
Forks
301
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Problem Description:**
#170 added Dark Mode support in a simplistic manner: If running on iOS 13, use whatever color is provided by the operating system for the Dynamic Color `systemBackground`

If an App opts out of Dark Mode support by setting User Interface Style to .light in Info.plist, the dynamic colors match the old behavior. But it is also valid to honor Dark Mode and [opt out for individual view controllers and their children](https://developer.apple.com/documentation/xcode/supporting_dark_mode_in_your_interface/choosing_a_specific_interface_style_for_your_ios_app).

Unfortunately, setting `overrideUserInterfaceStyle = .light` or passing a new UITraitCollection to new Window or ViewController does not change the definition of Dynamic Colors, when Dark Mode is enabled `systemBackground` is always black.

Suggestion:
1. easy - update BltnItemManager to take a (default nil) UITraitCollection
2. better - add `backgroundColor` and `defaultActivityIndicatorColor` to BLTNItemAppearance, update BltnItemManager to take an optional BltnInterfaceManager, and use the interfaceManager for both setting up the main card view, as well as passing it through to makeArrangedSubviews()

Thoughts?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.