alephium / alephium/alephium-frontend
Explorer address header mixes thousands separators
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 29
- Forks
- 27
- Avg merge
- 1h 52m
- Merged PRs (30d)
- 3
Description
Problem
The address page header renders three numbers side by side in the same InfoGrid, using two different thousands separators:
| Cell | Renders |
|---|---|
| ALPH balance | 108,033.9607 (comma) |
| Nb. of transactions | 7'219'800 (apostrophe) |
| Worth | 4'085.12 $ (apostrophe) |
Observed live on mainnet while fixing #350.
Expected
One consistent separator across the whole app. The apostrophe form appears to be the dominant convention in the explorer, so the ALPH balance is likely the odd one out - but worth confirming which formatter is canonical before changing it.
This probably also affects other pages that render ALPH balances, so it is worth grepping for the formatting helpers rather than patching this one cell.
Related: #128 (use locale number delimiters and currency format for displaying amounts).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the explorer address page's InfoGrid and grep the formatting helpers used for ALPH balances, transaction counts, and worth values. Confirm which formatter is canonical, then inspect other ALPH balance renderers mentioned by the issue. Done means the address header and affected pages use one consistent thousands separator.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100