alecthomas / alecthomas/entityx

Compiler warning in compile_time branch.

Open
#177 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
301
PR merge metrics
No merged PRs in 30d

Description

I'm seeing this warning from the compile_time branch:

```entityx\entityx/entityx.hh(240): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data```

Because
```
struct Components {
...
template
static void destroy(Storage &storage, const std::bitset &mask, std::size_t index) {
if (mask.test(component_index::value)) {
storage.template destroy(index);
}
}
```
The `Components.destroy` method takes size_t (and it looks like most of the storage classes use size_t), but the index of an Id is `uint32_t`. I'm compiling a 64bit executable, so I guess size_t is a uint64_t on my machine.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.