alan-turing-institute / alan-turing-institute/sqlsynthgen

mypy

Open
#76 0 comments 1 reaction 0 assignees View on GitHub
good first issue
Dominant language
Python
Stars
12
Forks
4
PR merge metrics
No merged PRs in 30d

Description

We aren't checking any types that are imported from external libraries but it would be good if we did. I think the change we need to make is in [mypy.ini](https://github.com/alan-turing-institute/sqlsynthgen/blob/a033aabfb522220f669e16b3948f032aa095a56e/mypy.ini#L12) where we probably need to change to

```text
ignore_missing_imports = False
```

There may be other checks that we want to make stricter too.

Contributor guide

Open the contributing guide

Research direction

Review mypy.ini around line 12 and inspect the current mypy configuration. Run the project's mypy checks with external-import checking enabled, then assess any resulting errors and the other checks that should be stricter. Done means the intended stricter type checking is configured and the resulting checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.